Skip to content

Comments

Test dependency fixes#11172

Open
BorisTheBrave wants to merge 3 commits intopydata:mainfrom
BorisTheBrave:test-dependency-fixes
Open

Test dependency fixes#11172
BorisTheBrave wants to merge 3 commits intopydata:mainfrom
BorisTheBrave:test-dependency-fixes

Conversation

@BorisTheBrave
Copy link

I had to add these dependencies I'm unclear how you found things working without these changes.

  1. Since v1.8, h5netcdf does not install h5py by default. This lets you swap back ends, which is cool. But io is meant to be a quick shorthand, I doubt users want stuff to be broken by default.

  2. pytz is now an optional dependency of pandas.. xarray uses it for a single test. Potentially that test should be dropped or swapped for zoneinfo, but this was most straightforward.

NB: I also had to install tzdata before the pytz test worked. But I think that is specific to my setup, I think timezone data is available commonly enough that it doesn't make sense to add a dependency.

@welcome
Copy link

welcome bot commented Feb 14, 2026

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this PR together! It seems reasonable to me. I think the reason why this wasn't caught in CI is because the dependencies for each testing environment is unrelated to these optional dependency lists. If you look at pixi.toml you'll see that h5py is explicitly included in the dependencies for backend tests.

Now I am not quite sure why this is failing tests. Might need @VeckoTheGecko to advise on that.

@VeckoTheGecko

This comment was marked as outdated.

@VeckoTheGecko
Copy link
Contributor

Ah ! CI failure due to Parcels-code/pixi-lock#14

@VeckoTheGecko
Copy link
Contributor

CI is running again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants