Open
Conversation
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
jsignell
reviewed
Feb 23, 2026
Member
jsignell
left a comment
There was a problem hiding this comment.
Thanks for putting this PR together! It seems reasonable to me. I think the reason why this wasn't caught in CI is because the dependencies for each testing environment is unrelated to these optional dependency lists. If you look at pixi.toml you'll see that h5py is explicitly included in the dependencies for backend tests.
Now I am not quite sure why this is failing tests. Might need @VeckoTheGecko to advise on that.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Ah ! CI failure due to Parcels-code/pixi-lock#14 |
2 tasks
Contributor
|
CI is running again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to add these dependencies I'm unclear how you found things working without these changes.
Since v1.8, h5netcdf does not install h5py by default. This lets you swap back ends, which is cool. But
iois meant to be a quick shorthand, I doubt users want stuff to be broken by default.pytz is now an optional dependency of pandas.. xarray uses it for a single test. Potentially that test should be dropped or swapped for zoneinfo, but this was most straightforward.
NB: I also had to install
tzdatabefore the pytz test worked. But I think that is specific to my setup, I think timezone data is available commonly enough that it doesn't make sense to add a dependency.