Add complex dtype support to FillValueCoder for Zarr backend#11151
Open
maxrjones wants to merge 6 commits intopydata:mainfrom
Open
Add complex dtype support to FillValueCoder for Zarr backend#11151maxrjones wants to merge 6 commits intopydata:mainfrom
maxrjones wants to merge 6 commits intopydata:mainfrom
Conversation
github-actions
bot
added
topic-backends
topic-zarr
dcherian
approved these changes
Feb 10, 2026
Contributor
Author
|
@dcherian thanks for your review. Do I need to get mypy working for this PR to go into main? The failures are in the function that I worked on, but unrelated to the changes that I made. |
dcherian
reviewed
Feb 13, 2026
| """Test that FillValueCoder round-trips complex fill values.""" | ||
| from xarray.backends.zarr import FillValueCoder | ||
|
|
||
| for value in [dtype(1 + 2j), dtype(-3.5 + 4.5j), dtype(complex("nan+nanj"))]: |
Contributor
There was a problem hiding this comment.
we need to test for infs here too i guess. A roundtrip property test in https://github.com/pydata/xarray/blob/main/properties/test_encode_decode.py would be nice. Are you up for it?
Contributor
Author
There was a problem hiding this comment.
sounds good, I'll add that
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for encoding/decoding complex fill values (complex64, complex128) in the Zarr backend's FillValueCoder, which previously raised ValueError for complex dtypes. This enables converting/virtualizing NetCDF files with these fill values to Zarr. As an example, this change unlocks virtualizing full NISAR granules using VirtualiZarr + Xarray.
Each component (real/imag) is base64-encoded as a little-endian double, consistent with how float fill values are already handled and ensuring safe JSON round-tripping of special values like NaN and Infinity.
whats-new.rstapi.rst