Bump the minimum version of h5netcdf to 1.4.0 in accordance with nep29 #11068
+11
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
force-pushed
the
bump_h5netcdf_nep29
branch
2 times, most recently
from
645dd2b to
317ef3a
Compare
4 tasks
Contributor
Author
hmaarrfk
force-pushed
the
bump_h5netcdf_nep29
branch
from
317ef3a to
60c4a86
Compare
hmaarrfk
force-pushed
the
bump_h5netcdf_nep29
branch
from
60c4a86 to
6a099c6
Compare
Contributor
Author
|
If you all accept this, do you want an error raised at runtime: xarray/xarray/backends/h5netcdf_.py Line 133 in 018ad08 |
keewis
approved these changes
Jan 5, 2026
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
looks good to me, our policy allows the bump already, see the "minimum versions" ci (if we want to discuss bumping h5netcdf to require the changes you mentioned in the different issue that should be done in a separate PR).
We will have to fix the mypy errors before merging, though.
keewis
reviewed
Jan 5, 2026
hmaarrfk
force-pushed
the
bump_h5netcdf_nep29
branch
3 times, most recently
from
0d9ee78 to
5732672
Compare
| version | date | | :-----: | :--------: | | 1.7.0 | 2025-10-15 | | 1.6.0 | 2025-03-07 | | 1.5.0 | 2025-01-26 | | 1.4.0 | 2024-10-07 |
hmaarrfk
force-pushed
the
bump_h5netcdf_nep29
branch
from
5732672 to
de0b60e
Compare
hmaarrfk
commented
Jan 5, 2026
hmaarrfk
changed the title
Contributor
Author
|
thanks for the reviews. i think this should be ready to go. |
dcherian
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this bug showed up in #11067
hopeing to just shed maintainance instead of fixing things there.
whats-new.rstapi.rst