Skip to content

fix: VarLookupDict __iter__ + DataFrame dtype compat (fixes #259, #232) #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kouyouqi123 wants to merge 3 commits into
base: master
Choose a base branch
from
+16 −1
Open

fix: VarLookupDict __iter__ + DataFrame dtype compat (fixes #259, #232) #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db9788a
fix: implement __iter__ on VarLookupDict to prevent CPython crash
kouyouqi123 May 31, 2026
611e509
fix: use np.asarray(result).dtype instead of result.dtype for DataFra…
kouyouqi123 May 31, 2026
128b51d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion patsy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ def _eval_factor(factor_info, data, NA_action):
if not safe_issubdtype(np.asarray(result).dtype, np.number):
raise PatsyError(
"when evaluating numeric factor %s, "
"I got non-numeric data of type '%s'" % (factor.name(), result.dtype),
"I got non-numeric data of type '%s'"
% (factor.name(), np.asarray(result).dtype),
factor,
)
return result, NA_action.is_numerical_NA(result)
Expand Down
14 changes: 14 additions & 0 deletions patsy/eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,20 @@ def get(self, key, default=None):
except KeyError:
return default

def __iter__(self):
seen = set()
for d in self._dicts:
for key in d:
if key not in seen:
seen.add(key)
yield key

def __len__(self):
return len(list(iter(self)))

def keys(self):
return list(iter(self))

def __repr__(self):
return "%s(%r)" % (self.__class__.__name__, self._dicts)

Expand Down
Loading