Skip to content

minor hardening #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

minor hardening #3426

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acfaadb
check for None
lars20070 Nov 14, 2025
97fa40f
fix linter
lars20070 Nov 14, 2025
549dcc9
revert formatting
lars20070 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pydantic_ai_slim/pydantic_ai/providers/google.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,5 +219,6 @@ class _NonClosingApiClient(BaseApiClient):
async def aclose(self) -> None:
# The original implementation also calls `await self._async_httpx_client.aclose()`, but we don't want to close our `cached_async_http_client` or the one the user passed in.
# TODO: Remove once https://github.com/googleapis/python-genai/issues/1566 is solved.
if self._aiohttp_session:
await self._aiohttp_session.close() # pragma: no cover
session = getattr(self, '_aiohttp_session', None)
if session is not None:
await session.close() # pragma: no cover