Repository navigation
Link the Pybricks logos rather than keep copies - #10
Merged
Merged
Conversation
The repository is not to carry the Pybricks logos. The two it had, the mark in the docs header and the app icon used as the favicon and at the top of the README, were byte-for-byte copies of pybricks-code's src/editor/logo.svg and src/about/icon.svg, so they are now linked from there and the copies are gone. The links name pybricks-code's v2.2.0 tag rather than its main branch. At that tag the files are the ones that were here, so nothing looks different, and a file moved or renamed on the main branch cannot take the site's logo with it. raw.githubusercontent.com serves them as image/svg+xml, which a browser will render from another origin. None of the published packages ever contained either file: their sdists and wheels hold only each package's own source, README and LICENSE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Pybricks logos from the repository and links to them from pybricks-code instead.
docs/assets/pybricks-logo.svg(the white mark in the docs header) anddocs/assets/pybricks-icon.svg(the app icon, used as the favicon and at the top of the README). Both were byte-for-byte copies of pybricks-code'ssrc/editor/logo.svgandsrc/about/icon.svg.properdocs.yml(theme.logo,theme.favicon) and the README's header image point at those files onraw.githubusercontent.com, pinned to pybricks-code'sv2.2.0tag. At that tag the files are identical to the ones removed, so nothing looks different. Pinning to the tag means a file moved on pybricks-code's main branch can't break the site's logo.docs/assets/pb.svg, the terminal screenshot made bytools/screenshot.py. It contains no logo.Checked:
pybricks-core,pybricks-clientandpybricks-service1.0.0b1 never contained either file. None of the 204 files across their wheels and sdists is an image, and their READMEs embed none.pybricks-cliis built the same way.The deleted files are still in the git history, which is public now. Removing them from there would mean rewriting
main.