Fixed #133 forwarding user target_compatible_with flags#135
Open
mikael-s-persson wants to merge 1 commit into
Open
Fixed #133 forwarding user target_compatible_with flags#135mikael-s-persson wants to merge 1 commit into
mikael-s-persson wants to merge 1 commit into
Conversation
AustinSchuh
approved these changes
Jul 2, 2026
AustinSchuh
left a comment
AustinSchuh
left a comment
There was a problem hiding this comment.
Not that my review counts, but this looks good!
Mizux
reviewed
Jul 2, 2026
| **kwargs): | ||
| """Builds a Python extension module using pybind11. | ||
|
|
||
| Args: |
Collaborator
There was a problem hiding this comment.
can you add a description of this new parameter here ?
Author
There was a problem hiding this comment.
What do you mean? target_compatible_with is a base/common attribute of all rules in Bazel, it's implied to potentially be part of kwargs like any other of the many common attributes. https://bazel.build/reference/be/common-definitions#common.target_compatible_with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #133