feat: expose API for modifying channel names#225
Open
tlambert03 wants to merge 1 commit intopyapp-kit:mainfrom
Open
feat: expose API for modifying channel names#225tlambert03 wants to merge 1 commit intopyapp-kit:mainfrom
tlambert03 wants to merge 1 commit intopyapp-kit:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 86.33% 85.24% -1.09%
==========================================
Files 46 46
Lines 5209 5239 +30
==========================================
- Hits 4497 4466 -31
- Misses 712 773 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gselzer
reviewed
Jan 6, 2026
Collaborator
gselzer
left a comment
gselzer
left a comment
There was a problem hiding this comment.
Hey, thanks! Was gonna make this change myself but a few things got in the way
| self.lut_views: list[LutView] = [] | ||
| self.lut_model = lut_model | ||
| self.lut_model.events.clims.connect(self._auto_scale) | ||
| self.lut_model.events.name.connect(self._on_name_changed) |
Collaborator
There was a problem hiding this comment.
For parity with other LUTModel fields, could we connect this signal in LutView.model?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #223