Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.90%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 86.11% 84.35% -1.77%
==========================================
Files 46 48 +2
Lines 5214 5323 +109
==========================================
Hits 4490 4490
- Misses 724 833 +109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alisterburt
approved these changes
Jun 9, 2024
alisterburt
left a comment
alisterburt
left a comment
There was a problem hiding this comment.
Loooove it, just got off the plane but excited to give it a whirl! Thanks for the effort 🙂
src/ndv/io.py
Outdated
|
|
||
|
|
||
| def imread(path: str | Path) -> Any: | ||
| """Just read the thing already.""" |
Closed
tlambert03
force-pushed
the
cli
branch
2 times, most recently
from
5f4c7b1 to
1e9fb46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4
this PR adds a cli command
ndv... and attempts to read basically anything 😂 as per @alisterburt request :)it's a work in progress... would be installed via
pip install ndv[io]and would lean heavily on aicsimagieo (or bioio, not sure yet) as well as some additional stuff