feat: add XYZ scale to ArrayDisplayModel#165
feat: add XYZ scale to ArrayDisplayModel#165tlambert03 wants to merge 5 commits intopyapp-kit:mainfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (64.70%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
===========================================
- Coverage 86.11% 44.85% -41.27%
===========================================
Files 46 46
Lines 5214 5246 +32
===========================================
- Hits 4490 2353 -2137
- Misses 724 2893 +2169 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
one challenge this PR generally exposes: how does a user pass data-related metadata (like channel names, scales, etc...). Yes, we support named arrays and we try to get all this info from xarray etc... but i don't want someone to have to create an xarray just to add some metadata. The this PR could just make the visualization possible, without weighing in on the public API |
something we've needed here at the QI course...
exposes the ability to set the scale part of the transform (and only the scale for now) on the image being displayed. mostly needed for anisotropic z sampling
may introduce some additional changes needed for the camera centering