feat: support iconify icon keys#130
Merged
tlambert03 merged 13 commits intopyapp-kit:mainfrom Oct 31, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 31 31
Lines 1746 1748 +2
=======================================
+ Hits 1738 1740 +2
Misses 8 8
☔ View full report in Codecov by Sentry. |
Member
Author
|
cc @jni, @Czaki ... nothing here affects napari, since napari still doesn't use app-model for it's icons. But plugins could conceivable in the future if anyone starts using the |
Member
Author
|
I pulled off the color spec into #132 ... not entirely sure about that part yet. so this is just iconify now |
…p-model into icon-color-iconify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
see #132 for follow up with color stuff