Edit the "first time contributor" message to instruct submitter to include the PR checklist - #2870
Merged
Merged
Conversation
AdamRJensen
approved these changes
Sep 28, 2026
cwhanse
approved these changes
Sep 28, 2026
RDaxini
approved these changes
Sep 28, 2026
Member
There was a problem hiding this comment.
I agree with the motivation and approve the PR.
Just to add something though: the (optimistic) idea/hope was that people would read the contributing guidelines, which clearly state this requirement for the checklist to be retained even in cases where the (AI) workflow overrides it. The lack of adherence to this requirement is to me a sign that people aren't reading the contributing guidelines.
Not sure where I am going with this. I am not requesting any changes, but I just felt like making this observation...
echedey-ls
reviewed
Sep 28, 2026
Comment on lines
+25
to
+26
| Finally, be sure the PR description includes the PR | ||
| [checklist](https://github.com/pvlib/pvlib-python/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
There was a problem hiding this comment.
Nvm, I misinterpreted the content on mobile.
echedey-ls
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib licenseno AI[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Many PRs from first-time contributors do not include the PR checklist. Perhaps including it in the automated message will help with that?