Skip to content

chore(deps): drop platform-node-shared override - #86

Merged
altaywtf merged 1 commit into
mainfrom
chore/drop-effect-override
Oct 1, 2026
Merged

altaywtf merged 1 commit into
mainfrom
chore/drop-effect-override

Conversation

@altaywtf

@altaywtf altaywtf commented Oct 1, 2026

Copy link
Copy Markdown
Member

Removes the @effect/platform-node-shared override. The package already pins it to 4.0.0 as a direct dependency, and the lockfile resolves a single 4.0.0.

  • docs/DISTRIBUTION.md said the Effect pins share a "prerelease" and pointed at the override; it now describes the exact-version pins without it.
  • pnpm exec vp run verify passes: 165 tests.

Written by an agent (Claude Code, Opus 5.5).

Copilot AI balanced review requested due to automatic review settings October 1, 2026 08:35
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The removed override was redundant given the existing direct exact-version pin, and the lockfile still resolves a single 4.0.0 with the docs updated to match.

Review effort: Balanced
Findings: None

What changed in this PR

This PR removes the now-redundant @effect/platform-node-shared pnpm override. Since package.json already pins @effect/platform-node-shared to the exact version 4.0.0 as a direct dependency (and @effect/platform-node@4.0.0 also depends on @effect/platform-node-shared@4.0.0), the override no longer changes resolution — the lockfile resolves a single 4.0.0. This keeps the Effect dependency pins aligned while trimming maintenance overhead, and updates the distribution docs to describe the exact-version pinning rationale rather than the removed override/"prerelease" wording.

Changes:

  • Dropped the @effect/platform-node-shared: 4.0.0 entry from the overrides block in pnpm-workspace.yaml and pnpm-lock.yaml.
  • Rewrote the Effect pin-alignment paragraph in docs/DISTRIBUTION.md to describe exact-version pins and the compatibility rationale instead of referencing pnpm overrides and a "prerelease".
File Description
pnpm-workspace.yaml Removes the redundant platform-node-shared override entry (direct exact pin already covers it).
pnpm-lock.yaml Mirrors the override removal in the resolved lockfile; resolution stays a single 4.0.0.
docs/​DISTRIBUTION.md Updates the Effect pin-alignment guidance to reflect exact-version pins without the override.

I verified that @effect/platform-node-shared remains a direct exact-version dependency (package.json:63), that it is the only consumer alongside @effect/platform-node@4.0.0 and both resolve to the single 4.0.0 in the lockfile, and that the minimumReleaseAgeExclude entry for the package is correctly retained since it is still a direct dependency. No issues found.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@altaywtf
altaywtf merged commit 067675b into main Oct 1, 2026
7 checks passed
@altaywtf
altaywtf deleted the chore/drop-effect-override branch October 1, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants