Skip to content

chore(deps): upgrade to Vite+ 1.0.0, Vitest 5.0.1, and Effect 4.0.0-rc.118 - #89

Merged
altaywtf merged 2 commits into
mainfrom
chore/vite-plus-1.0
Sep 28, 2026
Merged

altaywtf merged 2 commits into
mainfrom
chore/vite-plus-1.0

Conversation

@altaywtf

Copy link
Copy Markdown
Member

What changed

  • Vite+ 0.2.9 → 1.0.0 (vite catalog alias → @voidzero-dev/vite-plus-core@1.0.0), Vitest and @vitest/coverage-v8 4.1.10 → 5.0.1.
  • effect, @effect/platform-node, @effect/platform-node-shared, and @effect/vitest 4.0.0-rc.109 → 4.0.0-rc.118. @effect/vitest rc.118 is the first release with a vitest >=5 <6 peer.
  • minimumReleaseAgeExclude: the rc.109 entries now name rc.118, which was published today. pnpm added exact-version exclusions for the Vite+ 1.0.0 packages.
  • voidzero-dev/setup-vp is pinned to 3754dd7dbdb32bd8f6d28b6043de13ad3a75f21f # v1.21.1 in backfill-release-assets.yml (was v1.18.0) and in the .github/actions/setup-vp composite action (was v1.15.0), so every setup-vp use runs the same version. The composite action was not in the original request.

Why the source edits

Effect rc.118 removed the effect/unstable/* entry points and renamed the CLI constructors. Every edit below is mechanical and changes no behavior:

  • effect/unstable/cli → effect/cli: 11 imports in src/, plus the path references in AGENTS.md and docs/ARCHITECTURE.md.
  • Flag.string/boolean/integer/choice → Flag.String/Boolean/Int/Literals, Argument.string/integer → Argument.String/Int, and Config.string → Config.String: src/internal/command.ts, src/internal/config.ts, src/commands/auth.ts, and src/commands/files.ts.
  • scripts/smoke-packed-install.mts checks that the installed package has one Effect runtime at the pinned version, so its expected version is now rc.118.

No test needed changing, and the Vitest 5 vi.fn() dts issue does not affect this repository because pack.dts is off.

Proof

  • pnpm exec vp run verify exits 0: architecture check, knip, vp check ., skill lint, and smoke:pack (status: passed, 14 proofs including single-effect-runtime). Vitest reports 33 files and 368 tests passing.
  • Type delta against main: I ran tsc --noEmit with the repository tsconfig (minus baseUrl) on main at rc.109 and on this branch, then diffed the error lists with comm. Before the renames the branch had 26 new errors. After them, the diff is empty in both directions.
  • Built binary: ./dist/bin.mjs describe, version, and --help work. files hls-manifest abc and files list --output bogus reject invalid input with the same messages as the rc.109 build, which confirms Int and Literals behave like integer and choice.

Skipped: verify:sea (needs the credentialed SEA build) and the whoami runtime proof (needs live auth).

Found while testing (not changed here)

There is no working typecheck gate. tsconfig.typecheck.json fails under TypeScript 7 because baseUrl was removed, and main has about 20 existing type errors, mostly in tests. This PR leaves the count the same.

…c.118

Effect rc.118 removed effect/unstable/*; the CLI modules now live at
effect/cli, and Flag/Argument/Config constructors are PascalCase
(string/boolean/integer/choice -> String/Boolean/Int/Literals).
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T15:36:21.072863Z 1909577 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf
altaywtf merged commit d6fc2d8 into main Sep 28, 2026
6 checks passed
@altaywtf
altaywtf deleted the chore/vite-plus-1.0 branch September 28, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant