chore(deps): upgrade to Vite+ 1.0.0, Vitest 5.0.1, and Effect 4.0.0-rc.118 - #89
Merged
Merged
Conversation
…c.118 Effect rc.118 removed effect/unstable/*; the CLI modules now live at effect/cli, and Flag/Argument/Config constructors are PascalCase (string/boolean/integer/choice -> String/Boolean/Int/Literals).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
vitecatalog alias →@voidzero-dev/vite-plus-core@1.0.0), Vitest and@vitest/coverage-v84.1.10 → 5.0.1.effect,@effect/platform-node,@effect/platform-node-shared, and@effect/vitest4.0.0-rc.109 → 4.0.0-rc.118.@effect/vitestrc.118 is the first release with avitest >=5 <6peer.minimumReleaseAgeExclude: the rc.109 entries now name rc.118, which was published today. pnpm added exact-version exclusions for the Vite+ 1.0.0 packages.voidzero-dev/setup-vpis pinned to3754dd7dbdb32bd8f6d28b6043de13ad3a75f21f # v1.21.1inbackfill-release-assets.yml(was v1.18.0) and in the.github/actions/setup-vpcomposite action (was v1.15.0), so every setup-vp use runs the same version. The composite action was not in the original request.Why the source edits
Effect rc.118 removed the
effect/unstable/*entry points and renamed the CLI constructors. Every edit below is mechanical and changes no behavior:effect/unstable/cli→effect/cli: 11 imports insrc/, plus the path references inAGENTS.mdanddocs/ARCHITECTURE.md.Flag.string/boolean/integer/choice→Flag.String/Boolean/Int/Literals,Argument.string/integer→Argument.String/Int, andConfig.string→Config.String:src/internal/command.ts,src/internal/config.ts,src/commands/auth.ts, andsrc/commands/files.ts.scripts/smoke-packed-install.mtschecks that the installed package has one Effect runtime at the pinned version, so its expected version is now rc.118.No test needed changing, and the Vitest 5
vi.fn()dts issue does not affect this repository becausepack.dtsis off.Proof
pnpm exec vp run verifyexits 0: architecture check, knip,vp check ., skill lint, andsmoke:pack(status: passed, 14 proofs includingsingle-effect-runtime). Vitest reports 33 files and 368 tests passing.main: I rantsc --noEmitwith the repository tsconfig (minusbaseUrl) onmainat rc.109 and on this branch, then diffed the error lists withcomm. Before the renames the branch had 26 new errors. After them, the diff is empty in both directions../dist/bin.mjs describe,version, and--helpwork.files hls-manifest abcandfiles list --output bogusreject invalid input with the same messages as the rc.109 build, which confirmsIntandLiteralsbehave likeintegerandchoice.Skipped:
verify:sea(needs the credentialed SEA build) and thewhoamiruntime proof (needs live auth).Found while testing (not changed here)
There is no working typecheck gate.
tsconfig.typecheck.jsonfails under TypeScript 7 becausebaseUrlwas removed, andmainhas about 20 existing type errors, mostly in tests. This PR leaves the count the same.