chore: untrack Python bytecode and label design tokens 3.3.0 - #181
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/__pycache__/phosphor_icons.cpython-313.pyc..gitignorealready ignores__pycache__/.designVersionlabel from 3.2.1 to 3.3.0. The vendoreddesign/tokens.dtcg.jsonhas the same SHA-256 (a915906…c0c6) asdist/tokens.dtcg.jsonat putio-designv3.3.0, so no token values change. The label appears in the generatedPutioDesignTokens.ktheader,design/README.md, and the two codegen and scheme tests. The scheme test is renamed totokensMatchDesign330; its assertions are unchanged.The gate stays
./gradlew verify :buildSrc:test. In Gradle 9.7.1 the rootverifytask can't depend on buildSrc tasks (Included build 'buildSrc' not found in build ':'); #180 tracks moving buildSrc to an included build../gradlew verify :buildSrc:testpassed locally before and after the change, withputio-sdk-kotlinat b9c6d94. After the change,generateDesignTokensre-ran and wrote the 3.3.0 header.