Merge pull request #340 from pusher/tech/higher-order-functions-performance

danielrbrowne · web-flow · commit bdb08d814a1f · 2021-02-12T15:44:22.000Z
Performance optimisations for higher-order functions usage
diff --git a/Sources/Models/PusherPresenceChannel.swift b/Sources/Models/PusherPresenceChannel.swift
@@ -160,7 +160,7 @@ public typealias PusherUserInfoObject = [String: AnyObject]
         - returns: The PusherPresenceChannelMember object for the given user id
     */
     open func findMember(userId: String) -> PusherPresenceChannelMember? {
-        return self.members.filter({ $0.userId == userId }).first
+        return self.members.first(where: { $0.userId == userId })
     }
 
     /**
diff --git a/Sources/Services/PusherConnection.swift b/Sources/Services/PusherConnection.swift
@@ -475,7 +475,7 @@ import NWWebSocket
 
         chan.auth = nil
 
-        while chan.unsentEvents.count > 0 {
+        while !chan.unsentEvents.isEmpty {
             if let pusherEvent = chan.unsentEvents.popLast() {
                 chan.trigger(eventName: pusherEvent.name, data: pusherEvent.data)
             }

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ public typealias PusherUserInfoObject = [String: AnyObject]`
`160`	`160`	`- returns: The PusherPresenceChannelMember object for the given user id`
`161`	`161`	`*/`
`162`	`162`	`open func findMember(userId: String) -> PusherPresenceChannelMember? {`
`163`		`- return self.members.filter({ $0.userId == userId }).first`
	`163`	`+ return self.members.first(where: { $0.userId == userId })`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ import NWWebSocket`
`475`	`475`
`476`	`476`	`chan.auth = nil`
`477`	`477`
`478`		`- while chan.unsentEvents.count > 0 {`
	`478`	`+ while !chan.unsentEvents.isEmpty {`
`479`	`479`	`if let pusherEvent = chan.unsentEvents.popLast() {`
`480`	`480`	`chan.trigger(eventName: pusherEvent.name, data: pusherEvent.data)`
`481`	`481`	`}`