Prefer checking 'isEmpty' == false on collection (for performance reasons)

danielrbrowne · danielrbrowne · commit 44536f1c40ba · 2021-02-12T14:55:02.000Z
diff --git a/Sources/Services/PusherConnection.swift b/Sources/Services/PusherConnection.swift
@@ -475,7 +475,7 @@ import NWWebSocket
 
         chan.auth = nil
 
-        while chan.unsentEvents.count > 0 {
+        while !chan.unsentEvents.isEmpty {
             if let pusherEvent = chan.unsentEvents.popLast() {
                 chan.trigger(eventName: pusherEvent.name, data: pusherEvent.data)
             }

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ import NWWebSocket`
`475`	`475`
`476`	`476`	`chan.auth = nil`
`477`	`477`
`478`		`- while chan.unsentEvents.count > 0 {`
	`478`	`+ while !chan.unsentEvents.isEmpty {`
`479`	`479`	`if let pusherEvent = chan.unsentEvents.popLast() {`
`480`	`480`	`chan.trigger(eventName: pusherEvent.name, data: pusherEvent.data)`
`481`	`481`	`}`