FRAM-134 FRAM-103 Fix stretched images and dithered black bars for Ink frame.

[jnross]

Supercedes #51 and #52, with the approach suggested in the comments there. This moves the special resizing of images for Ink to the end of the dithering step. This ensures that the resulting image is the right size, and that any black bars added to extend the image are not dithered and snowy.

I tested this by running imgproxy locally in docker like this:

docker run --name imgproxy -p 8080:8080 -e PUSH_S3_IMAGES_BUCKET=none -e PUSH_S3_RENDER_BUCKET=none -e IMGPROXY_USE_LOCAL="true" -e IMGPROXY_ALLOW_LOOPBACK_SOURCE_ADDRESSES=true -it imgproxy

And then I used URLs that pointed it to images running on a local simple HTTP server (i.e. python3 -m http.server 8080), with URLs like this:

http://localhost:8080/unsafe/rotate:0/width:1600/height:1200/rt:fit/dither:fs:opts05:w:61.02:-3.68:-2.42:r:24.26:39.62:29.22:g:31.12:-20.86:3.19:bk:9.37:9.19:-14.07:bl:27.85:5.29:-37.79:y:60.14:-11.6:63.22/padding:0:150:0:150/background:0:0:0/crop:472:436:nowe:0:16/plain/http://10.4.4.22:8000/IMG_0916.jpg?cs=srgb&w=1600&h=1200

Before	After

[notion-workspace]

The black bars are dithered. They should be solid.

[notion-workspace]

Images are stretching on Frame - Images from backend don’t match requested dimensions

[jtomson]

awesome

[jnross]

@jtomson : So... after this has landed, what's the process of deployment? Is this a deploybot thing? Can we pair up to go through it? Should we do it in the morning instead of end of day?

[jtomson]

@jnross sure we can pair up tomorrow! shocker - it's a little different than how we deploy everything else