Repository navigation
docs: draw the introduction diagram as columns on narrow screens - #22
Merged
Merged
Conversation
The page load vs. soft navigation diagram had a fixed 770px wide viewBox, so on a phone it was drawn at 0.4x and its notes came out under 5px. The figure now holds two drawings of the same lanes: rows, as before, and columns with the steps running top to bottom. A container query on the figure shows the columns when it is under 640px wide, where the rows would shrink the notes below 10px. The columns are about 312 wide, so a phone draws them close to their own size and each step stays next to its counterpart in the other lane. Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
The page load vs. soft navigation diagram on the Introduction page had a fixed 770px wide viewBox. On a phone it was drawn at 0.4× and its notes came out at 4.8px.
What changed
Measured (puppeteer, the drawing that is shown)
No horizontal scroll at any width. Lint, typecheck and build pass.
Screenshots
Mobile (390 × 844)
360px phone, and the diagram alone
Desktop (1440 × 900), unchanged
Full desktop pages
Screenshots live on the
pr-media/mobile-diagrambranch, which can be deleted once this is merged.