Repository navigation
Reduce matrix scheduling time and preserve queued work - #801
Open
thomashoneyman wants to merge 2 commits into
Open
thomashoneyman wants to merge 2 commits into
thomashoneyman wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #800. In that issue,
web-storage@5.0.1finished publishing to the registry and Pursuit, then timed out while solving its follow-up matrix jobs. Since we solve all the followups before we insert any jobs this means we ended up with zero matrix jobs queued. This doesn't affect the package publication per se, but it means the supported compilers list ends up being wrong. Retrying publication doesn't help because it just returns that the package was already published.There are two problems at play. First, calculating the matrix cascade is very slow. Second, if there is an issue and we don't schedule all the jobs, there's no way to do it after the fact. This change addresses the first problem and preserves work already queued. Here's what we do:
On the current registry index, using this method for
web-storage@5.0.1drops the cascade from 102.5 seconds before this change to 5.66 seconds afterward, about 18 times faster. Both runs produced the same 14 complete build plans, including dependency resolutions. The first plan was emitted after 0.37 seconds.Note: this doesn't add any kind of background scheduler. If work didn't get queued before an interruption it still won't be recovered automatically. Fixing that is a bigger job and probably needs a lil discussion.