Set permission variable in user permission_exists SQL EPP - #508
Open
davidassigbi wants to merge 1 commit into
Open
Set permission variable in user permission_exists SQL EPP#508davidassigbi wants to merge 1 commit into
davidassigbi wants to merge 1 commit into
Conversation
…spurious corrective runs The permission_exists.sql.epp template never assigned the SQL variable @Permission inside its loop, so it stayed NULL. Since permission_name = NULL is never TRUE, the onlyif subquery always returned NULL, ISNULL coerced it to 'REVOKE', and the check always saw a mismatch — causing Puppet to re-grant permissions on every run.
jst-cyr
force-pushed
the
fix/user-permission-onlyif-null-var
branch
from
August 20, 2026 19:19
16afdbf to
c948b64
Compare
Member
|
Running CI for this PR here: #510 |
Member
|
**Acceptance Test Results: ** https://github.com/puppetlabs/puppetlabs-sqlserver/actions/runs/32536992100 All green on acceptance. Next step is an engineering review when the team is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #509
The permission variable is not set in the template file
templates/query/user/permission_exists.sql.epp. This creates a faulty tsql query when checking if the user permission already exists. The@permissionSQL variable stays NULL, so the subqueryWHERE permission_name = @permissionnever matches,ISNULLalways returns 'REVOKE', and theonlyifcheck always fails — causing Puppet to re-apply permissions as corrective on every run.This commit sets the
@permissionvariable to fix this issue. Same class of bug as #500 which fixedtemplates/create/login/permission.sql.epp.