Repository navigation
Conversation
mehul-jain1
left a comment
There was a problem hiding this comment.
Looks good however few tests are failing for ubuntu/sles.
|
@skyamgarp : Are you still working through this? It looks like it needs a rebase and the Ubuntu 24 tests failed the last time. |
span786
left a comment
There was a problem hiding this comment.
Thanks @skyamgarp. The metadata change itself is fine, but it can't merge on the current CI evidence:
-
Ubuntu 24.04 acceptance is failing (blocking). The last run on this branch (20 Apr, run 24658164050) failed both
Ubuntu-24.04andUbuntu-24.04-arm, which are exactly the platforms this PR adds. Those logs have since expired (HTTP 410), so I can't tell from here whether it was the module or the environment.SLES-12/SLES-15also failed in that run, but they pass on every recent nightly onmain(31 Oct to 2 Nov), so that was most likely infra at the time. -
Rebase (blocking). The branch is 10 commits behind
main. Since then,puppetlabs/java, which the acceptance suite uses to install the JDK, declares24.04support. So a rebase and a fresh CI run may well clear the Ubuntu 24.04 failure on its own. If it still fails, please post the failing step or the keytool error and we can look at it together. -
Non-blocking: the PR description is still the empty template. A line saying what was tested on 24.04 would help whoever merges this.
I'll approve once a run on the rebased head is green for Ubuntu 24.04 (amd64 + arm).
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)