feat: JUnit import, LSP diagnostic fix, document validation#88
Merged
Conversation
added 3 commits
March 28, 2026 06:59
Track which files had diagnostics and explicitly clear them when they no longer have issues. Fixes stale diagnostics persisting after fixing cross-file link errors. Fixes: UCA-C-2 Refs: FEAT-066
…port Parse JUnit XML test results and write as rivet TestRun YAML. Maps testcase names to artifact IDs where possible (classname exact match, bracketed [ID] in name/classname, or classname.name fallback). Includes 16 unit tests covering all artifact ID heuristics and XML parsing (pass, fail, error, skip, multiple suites, bare testsuite). Implements: FEAT-071 Refs: REQ-040
…guidance Documents without YAML frontmatter are now logged at info level instead of silently skipped. AGENTS.md updated with document requirements and guidance to use rivet commands instead of recreating statistics/coverage manually. Refs: REQ-001
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 92c3d89 | Previous: 966b530 | Ratio |
|---|---|---|---|
store_insert/10000 |
13515427 ns/iter (± 1225945) |
10310723 ns/iter (± 589105) |
1.31 |
validate/10000 |
6044558 ns/iter (± 835500) |
4933013 ns/iter (± 60355) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
Refs: FEAT-071
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rivet import-results --format junit <file.xml>parses JUnit XML test results and writes rivet TestRun YAML. Maps testcase names to artifact IDs.Test plan
cargo test -p rivet-core -p rivet-cli— all passImplements: FEAT-071
Refs: REQ-040, FEAT-066
🤖 Generated with Claude Code