feat: draft-aware validation, render extraction, HTML export, marketplace CI#87
Merged
feat: draft-aware validation, render extraction, HTML export, marketplace CI#87
Conversation
SvgOptions now accepts a type_shapes HashMap mapping node types to custom SVG shape functions. The shape function receives (node_type, x, y, width, height, fill, stroke) and returns raw SVG element string. Falls back to default rect when no provider is registered. Trace: skip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Missing required links on draft artifacts now produce Info-level diagnostics instead of errors. Active and approved artifacts enforce full traceability as before. Implements: FEAT-070 Refs: DD-040, REQ-039
Moves every render function body from the 5271-line monolith into the render/ module as pure functions taking &RenderContext + params -> String. New render modules: - render/graph.rs — GraphParams, EgoParams, render_graph_view, render_artifact_graph - render/matrix.rs — MatrixParams, MatrixCellParams, render_matrix_view, render_matrix_cell_detail - render/coverage.rs — render_coverage_view - render/search.rs — render_search_view - render/results.rs — render_verification_view, render_results_view, render_result_detail - render/source.rs — render_source_tree_view, render_source_file_view, build_artifact_info, rewrite_image_paths, full syntax highlighting suite - render/diff.rs — DiffParams, render_diff_view - render/traceability.rs — TraceParams, TraceHistoryParams, render_traceability_view, render_traceability_history - render/externals.rs — render_externals_list, render_external_detail - render/doc_linkage.rs — render_doc_linkage_view serve/views.rs reduced from 5271 to 409 lines (all handlers are now thin wrappers: lock state, call as_render_context(), delegate to render fn). Removed dead code from serve/mod.rs: type_color_map() and badge_for_type() (now canonical in render/helpers.rs). Fixed documents.rs to reference build_artifact_info via crate::render::source instead of serve::views. cargo check -p rivet-cli: clean (0 warnings) cargo test -p rivet-cli: 22/22 pass Refs: DD-041
Tree now shows Graph, Matrix, Coverage, Source, Traceability, Doc Linkage alongside existing views. All render routes wired up. 231 Playwright tests pass. Refs: DD-041
Build VSIX on tag push, publish to Marketplace via VSCE_PAT secret. VSIX also attached to GitHub Release as download asset. Follows spar's established publishing pattern. Note: VSCE_PAT secret must be configured in GitHub repo settings. See: https://code.visualstudio.com/api/working-with-extensions/publishing-extension Refs: FEAT-066
Generates standalone HTML pages using shared render module. Includes CSS, Mermaid, navigation sidebar. No HTMX dependency. Implements: REQ-035 Refs: DD-041
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d72a216 | Previous: ec74759 | Ratio |
|---|---|---|---|
link_graph_build/10000 |
33285997 ns/iter (± 2184062) |
25520682 ns/iter (± 1774328) |
1.30 |
validate/100 |
42319 ns/iter (± 133) |
33376 ns/iter (± 202) |
1.27 |
diff/10000 |
9404932 ns/iter (± 688810) |
7794136 ns/iter (± 224826) |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
added 12 commits
March 27, 2026 19:08
JUnit XML import, conformance workflow, dogfooded test evidence. 492 artifacts, PASS, 0 warnings. Refs: REQ-040
Search workspace folders and up to 2 levels deep for rivet.yaml instead of assuming it's at the workspace root. Supports monorepos and multi-root workspaces. Configurable via rivet.projectPath setting. Refs: FEAT-066
Cmd+Shift+F in explorer opens QuickPick with live search via rivet/search LSP request. Searches artifact IDs, titles, and document titles. Debounced 150ms. Refs: FEAT-066
Refs: DD-041
…bility views Adds 6 new Playwright spec files covering views that previously had only smoke tests in routes.spec.ts: - traceability.spec.ts — filter form, coverage matrix, linkage chains, history endpoint, URL param filtering (13 tests) - doc-linkage.spec.ts — SVG graph, cross-doc links table, document summary, artifacts-not-referenced section (12 tests) - diff.spec.ts — base/head selectors, HEAD~1 comparison, diff summary structure, empty state (9 tests) - externals.spec.ts — empty state, configured table columns, unknown prefix 404 handling (8 tests, 1 skipped when no externals configured) - verification.spec.ts — stat grid, ver-row details, empty state hint, requirement links (9 tests) - export.spec.ts — rivet export --format html output: 24 tests covering file existence, content structure, per-artifact pages, no panics Total: 75 new tests (306 passing in full suite, 4 pre-existing failures in help-view.spec.ts and documents.spec.ts unchanged by this commit). Refs: FEAT-066, DD-041
- 75 new Playwright tests (traceability, doc-linkage, diff, externals, verification, export). Fix 4 pre-existing hx-get assertions. - Artifact search: rivet/search LSP request + QuickPick (Cmd+Shift+F) - AGENTS.md updated for v0.3.0 architecture - 310 Playwright tests pass, 1 skipped Refs: FEAT-066, DD-041
Requirement=rounded-rect, design-decision=diamond, feature=hexagon, loss=red-rect, hazard=triangle, system-constraint=octagon, uca=parallelogram. Refs: FEAT-066
Schema detail page shows fields table, link fields, traceability rules, artifact count, example YAML, and per-type linkage Mermaid diagram. Help page linkage diagram now uses subgraphs by domain (ASPICE/Safety/Dev) and includes link_type edges in addition to traceability rule edges. Refs: FEAT-066
Add tests for enhanced schema view (fields, links, diagram, example, artifact count), graph SVG custom shapes (polygons, rounded rects), and help page schema linkage Mermaid diagram. 320 Playwright tests pass. Refs: FEAT-066
- rivet/render now finds the artifact's exact line in the YAML file
using lsp_find_artifact_line (scans for 'id: {id}')
- WebView auto-refreshes current page on rivet/artifactsChanged
(previously only showed stale banner)
- Expanded VS Code extension tests (all commands, settings, activation)
Refs: FEAT-066
Tests verify: 9 commands registered, settings exist, extension activates, LSP publishes diagnostics, showDashboard/navigateTo execute without error, tree view refresh works. Refs: FEAT-066
Publish empty diagnostic lists for source files that no longer have validation errors. Previously, fixing a YAML error left stale diagnostics in VS Code until the editor was reloaded. Refs: FEAT-066
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Refs: FEAT-066
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status: draftartifacts produce Info-level diagnostics instead of errors. Active/approved artifacts enforce full traceability.render/module.serve/views.rsreduced from 5271 to 409 lines of thin wrappers. Single source of truth for HTML generation across serve, LSP, and export.rivet export --html— generates standalone static HTML site from render module. All pages with CSS, Mermaid, navigation. 529 pages for the self-dogfooding project.VSCE_PATsecret, attach to GitHub Release. Follows spar pattern.489 artifacts, PASS, 0 warnings. All tests pass. 231 Playwright tests pass.
Test plan
cargo test— all pass (rivet-cli + rivet-core)Implements: FEAT-070, REQ-035
Refs: DD-040, DD-041, REQ-039
🤖 Generated with Claude Code