Repository navigation
feat(verify): read artifacts through rivet, adopt score status vocabulary - #13
Merged
Merged
Conversation
…lary Closes #5 for rivet artifact files. - tools/verify.py reads artifacts with `rivet list --format json --full` instead of PyYAML. variants/bindings.yaml stays on PyYAML until pulseengine/rivet#1094. - All 34 artifacts move from `status: approved` to `status: valid`. The vendored score schema allows draft/valid/invalid/in_progress/obsolete; rivet v0.13.0 did not check the value, v0.41.1 rejects all 34. - CI installs rivet v0.41.1 (v0.13.0 has no `list --full`). - A build or discovery error on a waived comp-req is now FAILED, not KNOWN-GAP: only a test that ran and failed is waivable. - tools/test_verify.py: 9 bucketing cases with rivet and bazel stubbed, run in CI. Reverting the discovery-error fix fails exactly one case. - DR-KVS-ARTIFACTS-THROUGH-RIVET records the decision. Local evidence: rivet 0.41.1 `make validate`: PASS (18 warnings, unchanged) old PyYAML reader vs rivet reader: same 6 comp-reqs, same verified-by lists, same waivers; only order differs (rivet sorts by id) missing or failing rivet binary: verify.py exits 1 `make verify` with bazel: not run to completion locally (bazel server under taskpolicy -b did not start within 120 s on a loaded host); CI runs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjapTTSvsFZti3qcD56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5 for rivet artifact files (
artifacts/*.yaml).variants/bindings.yamlis not a rivet artifact file and stays on PyYAML until pulseengine/rivet#1094.Changes
tools/verify.pyreads artifacts withrivet list --format json --fullinstead ofyaml.safe_load.status: approvedtostatus: valid. The vendored score schema (vendor/rivet-schemas/score.yaml) allows onlydraft, valid, invalid, in_progress, obsolete. rivet v0.13.0 never checked the value, so CI'srivet validatewas blind to it. v0.41.1 rejects all 34.validis also eclipse-score's own term.list --full.verified-byentry or a bazel build/discovery error on a waived comp-req is now FAILED. Previously it was KNOWN-GAP, which let an unbuilt test pass the gate. Only a test that ran and failed can be waived.tools/test_verify.py: 9 bucketing cases with rivet and bazel stubbed. CI runs it beforemake verify.DR-KVS-ARTIFACTS-THROUGH-RIVETrecords the decision.Evidence (local)
make validatewith rivet 0.41.1verified-bylists, same waivers. Only the order differs because rivet sorts by id.tools/test_verify.pytest_waiver_does_not_cover_discovery_error)make verifywith real bazeltaskpolicy -bdid not connect within 120 s. CI'srivet + bazel + verifyjob is the first full run. Expected: 3 PASSED, 2 KNOWN-GAP, exit 0.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEjmjapTTSvsFZti3qcD56