Repository navigation
Drop the Incidental Count of the Gate's Reader Modules - #3495
Merged
Merged
Conversation
The sentence counted the reader modules, a second copy of the list just before it that goes stale when a reader is added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Owner
Author
|
A recorded local strict-review pass covers head |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation change was fully reviewed and has no unresolved blocking issues.
No open issues 🎉
What changed in this PR
This documentation-only pull request removes the incidental reader-module count from scripts/README.md, preventing the description from becoming stale as modules change.
Changes:
- Replaces the fixed count with a reference to the reader modules imported by
pr_review.py. - Preserves the explanation that those modules are tested through
test_pr_review.py.
| File | Description |
|---|---|
scripts/README.md |
Removes the incidental reader-module count and clarifies the relationship between the modules and their tests. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3495 +/- ##
========================================
Coverage 81.07% 81.07%
========================================
Files 26 26
Lines 8934 8934
========================================
Hits 7243 7243
Misses 1691 1691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptr727
added a commit
that referenced
this pull request
Oct 26, 2026
…3494) ## Summary Promotes the pull requests merged into develop since release 2.0.1189. - [#3493](#3493): the digest's rendering moves out of `scripts/pr_review.py` into a new pure reader module, `scripts/pr_review_digest.py`. `digest` stays as the shell that does the reads. The `status` header is an ordered field list and the window and truncation advisories an ordered table. Output is byte-identical over every existing case, and two new cases pin a crowded and a quiet digest whole. - [#3495](#3495): `scripts/README.md` drops its incidental count of the reader modules and names `pr_review.py` as what imports them, which this promotion's first review found. - [#3497](#3497): `wait`'s body moves out of `main` into `run_wait`, and the per-subcommand flag checks are read from a `FLAG_OWNERS` table in two passes, so a new owned flag is one row. The first error printed over 1904 bad command lines is unchanged, and a case pins the multi-flag order. Closes #3457 Closes #3458 ## Constituent coverage Each change this promotion carries had coverage on its own pull request into develop: | Pull request | Merged head | Coverage | | --- | --- | --- | | [#3493](#3493) | `3eb58d60` | attested local pass at the merged head, base `develop`. A Copilot round on the earlier head `023589f8` opened one finding, fixed in `3eb58d60` and resolved, so no Copilot round covers the merged head | | [#3495](#3495) | `aab59769` | attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its 1 changed file, no open findings | | [#3497](#3497) | `2ca2e75d` | attested local pass at the merged head, base `develop`. A Copilot round on the earlier head `d145242d` opened one finding, already fixed in `2ca2e75d` and resolved, so no Copilot round covers the merged head | 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Answers the finding on promotion #3494 that
scripts/README.md:9counted the reader modules ("three"), a second copy of the list just before it that goes stale when a reader is added. The sentence now reads "The reader modulespr_review.pyimports are tested throughtest_pr_review.py.", which also stops it leaning on "the gate", since the same paragraph defines a gate as a_lintor_gatescript and listspr_review.pyas a utility.Verification
A local strict review ran two rounds. Round 1 raised the "the gate's" antecedent, fixed in
aab59769, and round 2 raised none. The prose gate is clean.Pre-existing findings, not filed
scripts/README.md:9:pre-existing, the older "Where a case covers a table" sentence runs 43 words against the opt-in sentence-length check's 25.🤖 Generated with Claude Code