Skip to content

Split the Over-Length Comment Sentences in lib/sh/secrets.sh #3577

Closed

Description

@ptr727

Summary

lib/sh/secrets.sh has comment sentences over the 25-word cap that prose_lint.py's opt-in sentence-length check enforces. A carrier cannot fix them, since verbatim-tree fidelity byte-locks the copy at lib/fleet/sh/secrets.sh. So each carrier's --check sentence-length --diff <base> run reports them on the pull request that first carries the tree, as noise it can only dismiss.

Reproduction

From a hub checkout:

python3 scripts/prose_lint.py --check sentence-length lib/sh/secrets.sh

At hub main 1abb46f this reports 23 sentence-length violations, at lines 4, 6, 7, 11, 12, 25, 26, 27, 28, 30, 38, 43, 50, 59, 60, 92, 95, 96, 220, 235, 236, 237, and 238.

Ask

Split those comment sentences at the hub, per the carried-content rule that a class in byte-locked content is fixed at the hub rather than per instance. Every carrier then picks the fix up on its next carry.py apply.

Found while carrying lib/fleet/sh into ptr727/Blog (ptr727/Blog#561).

🤖 Generated with Claude Code

Activity

  1. added
    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings
    proseA defect in rule or procedure text
    on Oct 28, 2026
  2. added a commit that references this issue on Oct 28, 2026
    eb5e6f6
  3. added a commit that references this issue on Oct 29, 2026
    13c2b8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pre-existingReview finding classed pre-existing per local-strict-review Disposing of FindingsproseA defect in rule or procedure text

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions