Repository navigation
Say the Env File Is Sourced and Named, Not That ENV_FILE Is Sourced - #564
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
The review found no active issues, and the documentation change clearly distinguishes shell sourcing from the release script’s ENV_FILE usage.
No open issues 🎉
What changed in this PR
Clarifies that the environment file is sourced in the shell, while ENV_FILE names the file used by the release script.
Changes:
- Rephrases the ambiguous
ENV_FILEexplanation inOPERATIONS.md. - Preserves the rationale for using both shell sourcing and
ENV_FILE.
| File | Description |
|---|---|
OPERATIONS.md |
Clarifies the relationship between shell sourcing and the ENV_FILE variable. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #564 +/- ##
========================================
Coverage 53.98% 53.98%
========================================
Files 12 12
Lines 3412 3412
========================================
Hits 1842 1842
Misses 1570 1570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fixes the headline of Copilot's second round on promotion #562, which read
OPERATIONS.mdas sayingENV_FILEis sourced. The sentence "ENV_FILEis set as well as sourced" meant that the shell sources the file and the command also names it inENV_FILE. Read literally, it says the variable is sourced, so it now says "The file is both sourced in the shell and named inENV_FILE".Verification
commentslabel. The opt-insentence-lengthcheck flags only the older 38-word "The script reads its own file regardless" sentence on the same line.develop, raised none. It also sweptOPERATIONS.md,ENVIRONMENT.md,deploy/README.md,README.md, and.secrets/README.md. No other sentence saysENV_FILEor the script sources the file.Dropped findings
OPERATIONS.md:70: opt-insentence-lengthflags the 38-word "The script reads its own file regardless" sentence. This change does not write it. Class:style.🤖 Generated with Claude Code