Repository navigation
Name the Values make-release.sh Reads From Its Env File - #563
Conversation
The example template and two OPERATIONS.md sentences still credited the shell's sourced DEPLOY_ROOT, or every value in the file, to the script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only changes clarify the scripts’ environment inputs and deploy-root precedence, with no active review issues remaining.
No open issues 🎉
What changed in this PR
This documentation-only pull request clarifies which environment values make-release.sh reads directly and distinguishes them from values supplied to check-live-urls.sh through the shell.
Changes:
- Documents
DEPLOY_ROOT,DEPLOY_SSH_HOST, andSITE_BASE_URLas values read bymake-release.sh. - Clarifies deploy-root selection and precedence between the file value and an explicit argument.
- Distinguishes script reads from shell-sourced values used by
check-live-urls.sh.
| File | Summary |
|---|---|
OPERATIONS.md |
Clarifies environment-file reading, sourcing, and deploy-root precedence in local deployment guidance. |
.secrets/example.env |
Names the environment values consumed directly by make-release.sh. Review note: complete the possessive phrase “over the caller's” to clarify what is being overridden. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #563 +/- ##
========================================
Coverage 53.98% 53.98%
========================================
Files 12 12
Lines 3412 3412
========================================
Hits 1842 1842
Misses 1570 1570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fixes the two Copilot findings on promotion #562 and their siblings. After #561, some prose still credited the shell's sourcing, or every value in the file, for what
make-release.shreads itself..secrets/example.envnames the three values the script reads from the file:DEPLOY_ROOT,DEPLOY_SSH_HOST, andSITE_BASE_URL.OPERATIONS.md"Deploying locally" says the empty first argument leaves the root at theDEPLOY_ROOTthe script reads from the file.check-live-urls.shreads. It also says the root argument wins over the file'sDEPLOY_ROOT.Verification
commentslabel is not needed. The opt-insentence-lengthcheck flags only the older "Name the file in both places" sentence, which this change does not rewrite.develop. The first raised 2 findings on the rewritten paragraph, both fixed. The second raised none.Dropped findings
OPERATIONS.md:42: opt-insentence-lengthflags the 39-word "Name the file in both places" sentence. This change does not write it. Class:style.🤖 Generated with Claude Code