Skip to content

Name the Values make-release.sh Reads From Its Env File - #563

Merged
ptr727 merged 2 commits into
developfrom
feature/env-read-wording
Oct 28, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/env-read-wording

Conversation

@ptr727

@ptr727 ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the two Copilot findings on promotion #562 and their siblings. After #561, some prose still credited the shell's sourcing, or every value in the file, for what make-release.sh reads itself.

  • .secrets/example.env names the three values the script reads from the file: DEPLOY_ROOT, DEPLOY_SSH_HOST, and SITE_BASE_URL.
  • OPERATIONS.md "Deploying locally" says the empty first argument leaves the root at the DEPLOY_ROOT the script reads from the file.
  • The paragraph after it says sourcing supplies the values check-live-urls.sh reads. It also says the root argument wins over the file's DEPLOY_ROOT.

Verification

  • Hub prose gate: clean, so the comments label is not needed. The opt-in sentence-length check flags only the older "Name the file in both places" sentence, which this change does not rewrite.
  • Local strict review: two passes, recorded against develop. The first raised 2 findings on the rewritten paragraph, both fixed. The second raised none.

Dropped findings

  • OPERATIONS.md:42: opt-in sentence-length flags the 39-word "Name the file in both places" sentence. This change does not write it. Class: style.

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 28, 2026 14:27
The example template and two OPERATIONS.md sentences still credited the
shell's sourced DEPLOY_ROOT, or every value in the file, to the script.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 28, 2026 21:29
@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 96941d0e11403001d0d391ecd7bb6f991ba8c090, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 96a3b903-1b3b-4c42-a654-065e25c8c451
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes clarify the scripts’ environment inputs and deploy-root precedence, with no active review issues remaining.

No open issues 🎉

What changed in this PR

This documentation-only pull request clarifies which environment values make-release.sh reads directly and distinguishes them from values supplied to check-live-urls.sh through the shell.

Changes:

  • Documents DEPLOY_ROOT, DEPLOY_SSH_HOST, and SITE_BASE_URL as values read by make-release.sh.
  • Clarifies deploy-root selection and precedence between the file value and an explicit argument.
  • Distinguishes script reads from shell-sourced values used by check-live-urls.sh.
File Summary
OPERATIONS.md Clarifies environment-file reading, sourcing, and deploy-root precedence in local deployment guidance.
.secrets/​example.env Names the environment values consumed directly by make-release.sh. Review note: complete the possessive phrase “over the caller's” to clarify what is being overridden.

Review effort: Lite

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.98%. Comparing base (6671b6c) to head (96941d0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #563   +/-   ##
========================================
  Coverage    53.98%   53.98%           
========================================
  Files           12       12           
  Lines         3412     3412           
========================================
  Hits          1842     1842           
  Misses        1570     1570           
Flag Coverage Δ
python-3.13 53.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ptr727
ptr727 merged commit 7063a41 into develop Oct 28, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/env-read-wording branch October 28, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants