You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rename the Host Env Files to the Fleet's Underscore-Joined Form - #557
Renames Blog's host env files to the fleet's underscore-joined form, per the env and secret file naming rule #556 carried into CODESTYLE.md from hub f60f57d. That rule reaches a host-side file the repository's docs or scripts name, so blog.<server>.<environment>.env becomes blog_<server>_<environment>.env, with each field unchanged.
deploy/make-release.sh: DEFAULT_ENV_FILE is now ~/.secrets/blog_local_production.env, and the --help text and the naming comment match it.
Docs: .secrets/README.md, .secrets/example.env, ENVIRONMENT.md, OPERATIONS.md, README.md, capture/README.md, and deploy/README.md name the four files the new way. The tracked template's own name, example.env, already conformed, so only its comments change.
Hostnames such as the VPS staging FQDN are not env files and are unchanged.
Host-Side Step
Each host running make-release.sh renames its files when this merges. On a host holding all four:
Until a host renames its files, a run that names ENV_FILE is refused because the file is not found. A run that relies on the default reads no file and prints no ==> environment: line. It then exits at the usage text, or builds against a DEPLOY_ROOT and SITE_BASE_URL the shell already exported, so rename the files before the first run after this merges. The documented set -a; . ~/.secrets/... lines fail on the missing file first. CI reads no env file, so it is unaffected.
Ordering
#553 pairs with this change and lands second, so it reads the new names.
Local Review
One local strict review pass on the frontier tier, recorded. It found no defect in the diff and raised the rollout risk the host-side step above states. The unit suite, env_docs_gate.py, the prose gate, markdownlint, cspell, shellcheck, shfmt, and editorconfig-checker run clean apart from the comment-added lines below.
The comments label is on this PR because the edited make-release.sh comment lines trip the comment-added gate.
The carried CODESTYLE.md naming rule reaches a host-side file the
repository's docs or scripts name, so blog.<server>.<environment>.env
becomes blog_<server>_<environment>.env. make-release.sh's default and
every doc naming one of the four files change together.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The catalog still describes a blog. filename prefix that conflicts with the newly documented underscore-joined naming, which could mislead maintainers.
This pull request renames Blog’s host environment files from dot-separated names to the fleet-standard underscore-joined format and updates the release script and documentation accordingly.
Changes:
Updates make-release.sh defaults, help text, and naming comments.
Renames environment-file references across repository, operations, deployment, and capture documentation.
Updates the tracked environment template and secrets catalog.
Requires host-side environment files to be renamed before the next release run.
File
Summary
Review notes
README.md
Updates release instructions and environment-file references.
—
OPERATIONS.md
Renames environment files throughout operational procedures and tables.
—
ENVIRONMENT.md
Updates the naming convention and default environment path.
—
deploy/README.md
Revises deployment setup, examples, and environment-variable documentation.
—
deploy/make-release.sh
Uses the underscore-joined default environment file and updated help text.
—
capture/README.md
Updates capture setup instructions to use the renamed file.
—
.secrets/README.md
Updates the host environment-file catalog and references.
Nit, 4 votes: Update the stale description that says the files carry a blog. prefix.
.secrets/example.env
Updates the template’s filename examples to the underscore-joined form.
Nit, 1 vote: Reconcile the template scope description with the filename changes in the patch.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Approval should be deferred because automated review cannot verify that every host migrates the four live ~/.secrets files before the new default and documented ENV_FILE paths are used.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Correct PR description for renamed documented destinations
.secrets/example.env:7
Update the PR description to match this change. It says the tracked template already conformed, but this hunk changes its documented destinations from dotted names to underscore-joined names, so the summary is inaccurate about a changed file.
Update the PR description to match this change. It says the tracked template already conformed, but this hunk changes its documented destinations from dotted names to underscore-joined names, so the summary is inaccurate about a changed file.
Fixed in the PR description. It now says the template's own name, example.env, already conformed, so only its comments change. The file was already in the changed-files list on the same line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commentsPermits the comment lines the pull request adds or edits, which the prose gate otherwise refuses
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames Blog's host env files to the fleet's underscore-joined form, per the env and secret file naming rule #556 carried into
CODESTYLE.mdfrom hubf60f57d. That rule reaches a host-side file the repository's docs or scripts name, soblog.<server>.<environment>.envbecomesblog_<server>_<environment>.env, with each field unchanged.deploy/make-release.sh:DEFAULT_ENV_FILEis now~/.secrets/blog_local_production.env, and the--helptext and the naming comment match it..secrets/README.md,.secrets/example.env,ENVIRONMENT.md,OPERATIONS.md,README.md,capture/README.md, anddeploy/README.mdname the four files the new way. The tracked template's own name,example.env, already conformed, so only its comments change.Hostnames such as the VPS staging FQDN are not env files and are unchanged.
Host-Side Step
Each host running
make-release.shrenames its files when this merges. On a host holding all four:Until a host renames its files, a run that names
ENV_FILEis refused because the file is not found. A run that relies on the default reads no file and prints no==> environment:line. It then exits at the usage text, or builds against aDEPLOY_ROOTandSITE_BASE_URLthe shell already exported, so rename the files before the first run after this merges. The documentedset -a; . ~/.secrets/...lines fail on the missing file first. CI reads no env file, so it is unaffected.Ordering
#553 pairs with this change and lands second, so it reads the new names.
Local Review
One local strict review pass on the frontier tier, recorded. It found no defect in the diff and raised the rollout risk the host-side step above states. The unit suite,
env_docs_gate.py, the prose gate, markdownlint, cspell, shellcheck, shfmt, and editorconfig-checker run clean apart from the comment-added lines below.The
commentslabel is on this PR because the editedmake-release.shcomment lines trip the comment-added gate.🤖 Generated with Claude Code