Skip to content

feat: add typescript-best-practices, full statechart, and 4 verification skills - #13

Merged
caelaxie merged 1 commit into
mainfrom
feat/upstream-verification-statechart-ts
Nov 17, 2026
Merged

caelaxie merged 1 commit into
mainfrom
feat/upstream-verification-statechart-ts

Conversation

@caelaxie

Copy link
Copy Markdown
Contributor

Why

Align agy-pstack-next (v3.1.0) with upstream Cursor pstack (0.15.43) across TypeScript best practices, the full TLA+/Mermaid statechart compiler, and the four dedicated verification lifecycle skills—while preserving Antigravity compatibility, native swarm orchestration, and concurrent safety across multiple projects and linked git worktrees.

What changed

  • Added /typescript-best-practices (skills/typescript-best-practices/): Ported all 16 rules in SKILL.md and code examples in references/patterns.md, wired into /pstack and /crucible with Antigravity progressive-disclosure frontmatter and resolved <plugin-dir> worker brief pointers.
  • Restored full /statechart skill & compiler (skills/statechart/): Ported the upstream 0.15.43 zero-npm-dependency TypeScript compiler (scripts/statechart, including composite-state drawnEdges and sanyErrors fixes), references/render.md (pele@1.9.0 SVG theming), corpus fixtures, and test suite.
  • Replaced /verify-gen with the 4 upstream verification skills:
    • skills/create-verification-skill/ (plus references/feature-map-example/*) generating .agents/skills/verify-<app>/ and proving cold via an independent verifier.
    • skills/maintain-verification-skill/ running parallel inherit source-drift scouts + single-owner live verification (clean, changed, blocked).
    • skills/create-formal-verification-skill/ generating .agents/skills/verify-<area>-formal/ (TLA+, SMT, prover, or PBT) with scratch-break failure-sensitivity proof.
    • skills/maintain-formal-verification-skill/ syncing sync_commit..HEAD covered-code changes and separating verification drift from real product bugs (in sync, updated, bug, blocked).
  • Hardened multi-project & concurrent git-worktree isolation across all skills:
    • Anchor git operations to TARGET_CWD via git -C <TARGET_CWD> rev-parse --show-toplevel (never [ -d .git ]).
    • Check out candidate revisions via git checkout --detach FETCH_HEAD (eliminating crucible-synth shared-branch lock failures across linked git worktrees of the same repository).
    • Replace shell-$$ and flat /tmp paths with mktemp -d per-run directories (RUN_DIR), <appDataDir>/brain/<conversation-id>/scratch/ overflow reports, ephemeral ports (--port 0), isolated --user-data-dir profiles, dedicated tmux -L sockets, PID/worktree-revision Doctor checks, and PID/socket-only teardown.
  • Updated .antigravity-plugin/plugin.json (3.1.0), README.md, and .github/workflows/ci.yml: Enforce the 11-skill roster, frontmatter/link checks, executable statechart launcher, and full statechart + TLC test execution in CI.

Blast Radius

  • Breaking (verify-gen removal): Replaces /verify-gen (--formal, --maintain) with /create-verification-skill, /maintain-verification-skill, /create-formal-verification-skill, and /maintain-formal-verification-skill (7 -> 11 skills). Existing repo-local .agents/skills/verify-* suites continue working unchanged and gain full scripts/statechart compiler support.

Verification

  • agy plugin validate --strict --json . passed (11 skills, 0 findings).
  • Clean-HOME agy plugin install ., installed-copy --strict validation, and CI link/frontmatter/executable invariants passed (11 skills, 18 markdown files).
  • skills/statechart/scripts unit & CLI suites passed (270 passed locally; full TLC + fast-check + pele@1.9.0 suite wired in CI).
  • Executed two concurrent skills/statechart/scripts/statechart TLC runs in parallel mktemp -d directories (MediaPlayer.tla) and verified identical chart.mmd outputs with zero cross-run collision.

@caelaxie
caelaxie merged commit e32603d into main Nov 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant