Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallbackFileWrapper._close skips its cleanup when the cache callback raises. A cache write error or interruption therefore leaves the temporary file open and the callback attached; reading EOF again can call it again.
Run the existing callback-reference and temporary-file cleanup in finally. Keep the original exception propagation and callback data unchanged. Add tests using real http.client.HTTPResponse objects for empty/nonempty bodies, successful callbacks, OSError, and KeyboardInterrupt.
Validation on Linux, CPython 3.12.14:
This is deliberately narrow: a retained traceback can still hold the existing mmap view. Native Windows/macOS and the other Python versions have not been tested locally.
AI disclosure: prepared with OpenAI Codex assistance, including a separate automated review and consumer probe. No human manual review is claimed.