docs(review): correct the token claim in the merged #272 review - #311
Merged
Conversation
The review shipped saying a pairing-issued one-time token is spent on the first sweep tick before anyone spawns, and that an unbounded desktop seed is therefore effectively mandatory. That is wrong. The architect verified against a live server that the token is durable and re-exchangeable — nothing is burned. The real cost is smaller and different: each exchange mints a SESSION, so the sweep accumulates one per server every 30s. A leak, not a spent credential, and it wants a different fix — reuse the access token across ticks rather than provisioning another kind of credential. Tracked in #306. Corrected in place with the wrong version named rather than quietly rewritten, because it was merged and someone may have read it. A merged review is what gets grepped in six months. The underlying mistake is worth stating: I propagated a constraint documented in a comment on ThreadBackendConfig.bootstrapToken as though it were a measurement. It was not, and the live check disagreed with it. Refs #272, #306.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #272 review merged saying a pairing-issued one-time token is spent on the first sweep tick before anyone spawns, and that an unbounded desktop seed is therefore effectively mandatory for any workspace carrying a
threadsconfig.That is wrong. The architect verified against a live server that the bootstrap token is durable and re-exchangeable. Nothing is burned.
The real cost is smaller and different: each exchange mints a session, so the sweep accumulates one per server every 30s and they pile up. A leak, not a spent credential — and it wants a different fix (reuse the access token across ticks) than the one the wrong version implied (provision a different kind of credential). Tracked in #306.
Why correct it rather than leave it
A merged review is what someone greps in six months. This one currently tells them a credential is being burned that is not, and points at the wrong remedy.
The correction names the wrong version rather than quietly replacing it, because it was merged and someone may already have read it.
The mistake underneath
I propagated a constraint documented in a comment — on
ThreadBackendConfig.bootstrapToken— as though it were a measurement. It was not, and the live check disagreed with it. That is the repo's own "verify claims against the actual system, summaries are evidence not ground truth", applied to a code comment I had every reason to trust.One file, one paragraph. Refs #272, #306.
🤖 Generated with Claude Code