Fix #264: address the gate notification by worktree, not by project id

[pseudoseed]

Summary

A gate-approval notification could be delivered to a project that approved nothing. porch approve addressed the recipient by bare project id, and afx send resolved the workspace from the sending process's session and then matched the agent by tail — so 250 reached builder-spir-250 in whatever workspace the sender belonged to. An approval for a throwaway project in a temp workspace woke a live builder somewhere else, with a message indistinguishable from a real one.

This is a safety defect rather than a noisy one. A gate is where a human's authority enters the system; a notification that arrives without it is a channel around the --a-human-explicitly-approved-this apparatus.

Fixes #264

Root Cause

Two hops composed, neither carrying the identity of the project whose status.yaml was actually written.

Hop 1 — the recipient was a bare project id. commands/porch/index.ts:1267 sent target: state.id, which notify.ts turned into afx send <projectId> "<msg>" --raw.

Hop 2 — the workspace came from the sender, and the agent was tail-matched. agent-farm/commands/send.ts resolves the workspace from CODEV_THREAD_ID, else CODEV_BUILDER_ID + CODEV_WORKTREE_ROOT, else a cwd walk-up. The issue attributes this to cwd; the launch-identity env actually wins over cwd, which is why a Playwright suite running in spir-250's pane made a temp-workspace approval resolve to /Users/chris/dev/codev-1455. servers/tower-messages.ts then matched builderId.endsWith('-' + stripLeadingZeros(agent)).

The cluesmith#1094 guard did not fire because it checks that the sender's identity is verifiable, not that the recipient is correct. Both were perfectly verifiable.

Reproduced, both directions

Built a throwaway porch project in a temp workspace with a pending pr gate and ran porch approve from it. Before the fix the message landed in builder-bugfix-264's pane while that project's own pr gate stayed pending. With env -u CODEV_BUILDER_ID -u CODEV_WORKTREE_ROOT -u CODEV_THREAD_ID, nothing was delivered — the delta between those two runs is the whole mechanism.

Fix

• porch addresses the project's own worktree. notifyGateApproved sends afx send --worktree <artifactRoot> --exact. artifactRoot is the directory whose status.yaml was just written, so it names one builder in one workspace or it names nothing. notifyProtocolComplete is pinned the same way — it prompts afx cleanup, which is destructive.
• afx send --worktree <path> resolves the recipient and the resolution workspace from that path, scoped to the workspace that owns it. A worktree no builder owns throws, naming the worktree and listing who is registered. fromWorkspace still comes from the sender's session; those were one value and are now two. When the caller names its own target (architect), the path pins only the scope and no DB read happens, so an orphaned worktree cannot suppress the cleanup trigger.
• afx send --exact turns off the builder tail match in both Tower resolvers — live and the offline-hold registry. The miss names the address, the workspace, and the builders actually there.
• The message is checkable rather than an instruction. It names the project and workspace, says outright that it is not an approval and carries no authority, and says what to confirm against and what a mismatch means.

Note the safety property does not depend on Tower being upgraded first: porch now sends a canonical builder id, which cannot tail-match anything, so an older Tower that ignores exact still delivers correctly.

176 lines of production code across 8 files.

Test Plan

• Regression test added — bugfix-264-gate-notification-addressing.test.ts (resolver + worktree resolution, two-workspace fixture) and bugfix-264-gate-notify-addressing.test.ts (the argv and the message text)
• Both confirmed to fail with the corresponding half of the fix backed out (3 failures each), then restored
• Build passes
• All tests pass — 7413 passed, 58 skipped, 0 failed
• Original reproducer re-run against the fix: nothing delivered, named miss logged
• Live positive: afx send --worktree <my worktree> --exact delivered to builder-bugfix-264

Not in scope

Issue #185's "On it" false positive in the spawn render gate, per the architect — separate issue.

🤖 Generated with Claude Code