Repository navigation
ps2link: Harden TCP file-I/O socket lifecycle and malformed replies - #68
Merged
Merged
Conversation
Share socket-detach cleanup across shutdown, connection replacement and EOF, close on malformed reply headers and impossible read/write lengths, and guard against zero-progress write replies. Add native C reply validation tests and CI gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The IOP-side TCP file-I/O client could retain a stale socket after driver teardown or malformed replies. Wrong reply types/lengths leave unread bytes on the stream; zero-progress and oversized write counts were not consistently rejected.
Fix
Validation
LOADHIGH=1 ZEROCOPY=1cross-builds: passed locally.git diff --check: passed.This PR does not require any changes from #67 and does not alter the existing release job. The new check is independent and can be made a required status check in branch protection.