fix(csharp): cache extensions per descriptor - #29707
Open
awe123343 wants to merge 1 commit into
Open
Conversation
awe123343
requested review from
amanda-tarafa
and removed request for
a team
September 10, 2026 17:05
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
awe123343
force-pushed
the
fix/csharp-extension-cache-race
branch
2 times, most recently
from
September 10, 2026 17:38
e47fa97 to
d970869
Compare
awe123343
force-pushed
the
fix/csharp-extension-cache-race
branch
from
September 10, 2026 17:49
d970869 to
071aaa8
Compare
awe123343
commented
Sep 10, 2026
| private readonly Lazy<Dictionary<IDescriptor, DescriptorDeclaration>> declarations; | ||
|
|
||
| private static readonly Dictionary<string, List<Extension>> allDependedExtensionsCache = new(); | ||
| private List<Extension> allDependedExtensionsCache; |
Author
There was a problem hiding this comment.
I would argue we should not have started with a static map.
- The depended extensions are derived per descriptor, so the cache should live and die with the descriptor instance.
- The map breaks that ownership and keeps entries alive even after the descriptor itself is collectable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29696.
Synthetic retained parent/child initialisation, .NET 8 / ARM64: