Make rust_proto_library usable externally#28136
Open
korran wants to merge 1 commit into
Open
Conversation
Allow `rust_proto_library()` to be used from external projects. This makes `use_upb_kernel` public, and uses `Label` to ensure internal labels (for visibility and configuration) resolve to the protobuf repository instead of the downstream project.
korran
force-pushed
the
fix/hygienic-labels-and-visibility
branch
from
1971251 to
3aa1972
Compare
esrauchg
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
rust_proto_library()to be used from external projects. This makesuse_upb_kernelpublic, and usesLabelto ensure internal labels (for visibility and configuration) resolve to the protobuf repository instead of the downstream project.