feat(fmodata,typegen): add list type override with preserved custom list options#123
Merged
feat(fmodata,typegen): add list type override with preserved custom list options#123
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Collaborator
Author
eluce2
changed the base branch from
fix/fmodata-clearoldfiles-preserve-customizations
to
graphite-base/123
This commit updates the listField function to use a more efficient check for non-string items in the input array. It also adds a test case to ensure that undefined list items are correctly rejected without throwing an error when no itemValidator is provided, enhancing input validation and error handling.
eluce2
force-pushed
the
feat/list-field-type-override
branch
from
0aadfc7 to
40db5f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a new
listField()builder with non-trivial read/write validation plus updates the OData type generator’s customization-preservation logic; both could subtly change generated output and runtime coercion for list-backed fields.Overview
Adds a new
listField()to@proofkit/fmodatafor FileMaker return-delimited list strings, including newline normalization, optional nullability (allowNull), and optional per-item validation/transform (itemValidator), and exports it (andListFieldOptions) from the public API.Extends OData typegen to support a new
typeOverride: "list", auto-importlistField, and improvespreserveUserCustomizationsto keep user-authoredlistField({...})options when the field remains list-typed (and drop them when the type changes), with updated docs/UI/schema, snapshots, and new unit/e2e coverage; also splits Vitest config for default vs e2e runs and updates typegen test scripts.Written by Cursor Bugbot for commit 40db5f8. This will update automatically on new commits. Configure here.