chore(mixin): update NodeNetworkTransmitErrs/NodeNetworkReceiveErrs descriptions - #3752
Open
v-zhuravlev wants to merge 1 commit into
Open
chore(mixin): update NodeNetworkTransmitErrs/NodeNetworkReceiveErrs descriptions#3752v-zhuravlev wants to merge 1 commit into
v-zhuravlev wants to merge 1 commit into
Conversation
…escriptions Signed-off-by: v-zhuravlev <v-zhuravlev@users.noreply.github.com>
TheMeier
approved these changes
Jul 22, 2026
ArthurSens
requested changes
Aug 21, 2026
ArthurSens
left a comment
ArthurSens
left a comment
Member
There was a problem hiding this comment.
The query is actually a percentage, so this is probably a better fit :)
| annotations: { | ||
| summary: 'Network interface is reporting many receive errors.', | ||
| description: '{{ $labels.instance }} interface {{ $labels.device }} has encountered {{ printf "%.0f" $value }} receive errors in the last two minutes.', | ||
| description: '{{ $labels.instance }} interface {{ $labels.device }} has encountered {{ printf "%.2f" $value }} receive errors in the last two minutes.', |
Member
There was a problem hiding this comment.
Suggested change
| description: '{{ $labels.instance }} interface {{ $labels.device }} has encountered {{ printf "%.2f" $value }} receive errors in the last two minutes.', | |
| description: '{{ $labels.instance }} interface {{ $labels.device }} reported receive errors for {{ $value | humanizePercentage }} of packets in the last two minutes.', |
| annotations: { | ||
| summary: 'Network interface is reporting many transmit errors.', | ||
| description: '{{ $labels.instance }} interface {{ $labels.device }} has encountered {{ printf "%.0f" $value }} transmit errors in the last two minutes.', | ||
| description: '{{ $labels.instance }} interface {{ $labels.device }} has encountered {{ printf "%.2f" $value }} transmit errors in the last two minutes.', |
Member
There was a problem hiding this comment.
Suggested change
| description: '{{ $labels.instance }} interface {{ $labels.device }} has encountered {{ printf "%.2f" $value }} transmit errors in the last two minutes.', | |
| description: '{{ $labels.instance }} interface {{ $labels.device }} reported transmit errors for {{ $value | humanizePercentage }} of packets in the last two minutes.', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous descriptions could lead to confusing alert description like:
if the latest value is < 0.5