fix: prevent panic when using diskstats device-include only (#3590)#3603
Open
mumberrymountain wants to merge 1 commit intoprometheus:masterfrom
Open
Conversation
…us#3590) Signed-off-by: Jeon Insoo <mumberrymountain@gmail.com>
15bceac to
110272f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fix issue #3590.
Problem:
setting
--collector.diskstats.device-includealone trigger the “device-exclude & device-include are mutually exclusive” error and ultimately cause panic during handler creation.Cause:
collector.diskstats.device-excludehas a non-empty default on Linux,as a result, providing
device-includeonly still leaves device-exclude as default, so the code treats it as include+exclude all being set and throws error.Fix
When device-include is set: