chore: switch to github action#3602
Open
roidelapluie wants to merge 1 commit intoprometheus:masterfrom
Open
Conversation
roidelapluie
force-pushed
the
gha
branch
4 times, most recently
from
a55751c to
19d1920
Compare
SuperQ
reviewed
Apr 2, 2026
.github/workflows/ci.yml
Outdated
Comment on lines
+60
to
+62
| build_all: | ||
| name: Build node_exporter for all architectures | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
Should we do the same build/build_all here to reduce the CI time for PRs?
Member
Author
There was a problem hiding this comment.
CI time to build all is 5 minutes, to me it is acceptable.
Member
There was a problem hiding this comment.
Ok, maybe for exporters we should just have a single build step.
SuperQ
reviewed
Apr 2, 2026
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.