Alphabetize default metrics - #817
Open
jonsuguiyama wants to merge 1 commit into
Open
Conversation
Register default metric modules in alphabetical order of their metric name in defaultMetrics.js. Move the shared collect() in heapSizeAndUsed from the total gauge to the external gauge, since nodejs_external_memory_bytes now sorts first. Add a test asserting module registration order is alphabetical.
jdmarshall
reviewed
Aug 21, 2026
jdmarshall
left a comment
jdmarshall
left a comment
Contributor
There was a problem hiding this comment.
I'm on my way out the door at the moment but looks promising. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #810.
metricsobject inlib/defaultMetrics.jsalphabetically by each module's Prometheus metric name.heapSizeAndUsed.js, move the sharedcollect()from thetotalgauge to theexternalgauge, sincenodejs_external_memory_bytesnow registers first alphabetically.externalgauge first, since it now owns the shared collect.