fix(default-metrics): register metrics alphabetically - #811
Open
salman-frs wants to merge 1 commit into
Open
Conversation
Signed-off-by: salman-frs <sallman.alffarisi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default metrics currently follow collector registration order, so the output is not ordered by metric name.
This reorders metric groups and metrics inside multi-metric collectors where needed. Shared
collect()callbacks move to the first registered metric so sibling values are populated before the registry reads them.Collectors such as
heapSizeAndUsedregister names under more than one prefix, so object order alone cannot produce a globally sorted result.collectDefaultMetrics()therefore sorts only the newly registered default metrics once after registration. Existing custom metrics keep their registration order.Tests:
npm testbun test-unitFixes #810.