Skip to content

build: support running Maven with -T1C #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stephan202 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: support running Maven with -T1C #2407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4607767
build: declare missing reactor dependencies
Stephan202 Aug 20, 2026
16b24e9
test: bind `ExemplarTest`'s WireMock server to a dynamic port
Stephan202 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions integration-tests/it-exporter/it-exporter-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,36 @@
<version>${guava.version}</version>
<scope>test</scope>
</dependency>
<!-- Each integration test runs its sample application from the shaded jar
that the corresponding module leaves in `target`, a dependency Maven cannot
infer: it derives the reactor build order only from directly declared
dependencies. These declarations give it that order; without them serial
builds work only by accident of the module ordering in `../pom.xml`, while
`mvn -T` races against the sample modules and `mvn -am` skips them
entirely. -->
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>it-exporter-servlet-tomcat-sample</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>it-exporter-servlet-jetty-sample</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>it-exporter-httpserver-sample</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>it-exporter-duplicate-metrics-sample</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
</project>
13 changes: 13 additions & 0 deletions integration-tests/it-exporter/it-no-protobuf-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,18 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<!-- `NoProtobufIT` runs its sample application from the shaded jar that
`it-exporter-no-protobuf` leaves in `target`, a dependency Maven cannot
infer: it derives the reactor build order only from directly declared
dependencies. This declaration gives it that order; without it serial
builds work only by accident of the module ordering in `../pom.xml`, while
`mvn -T` races against the sample module and `mvn -am` skips it
entirely. -->
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>it-exporter-no-protobuf</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
</project>
16 changes: 16 additions & 0 deletions integration-tests/it-spring-boot-smoke-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,22 @@
<artifactId>micrometer-registry-prometheus</artifactId>
<scope>runtime</scope>
</dependency>
<!-- Already pulled in transitively by `micrometer-registry-prometheus`,
but declared explicitly (with the exclusion that
`micrometer-registry-prometheus` applies, so that the resolved set of
artifacts, their versions and their scopes is unchanged) because Maven
derives the reactor build order only from directly declared dependencies. -->
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>prometheus-metrics-core</artifactId>
<scope>runtime</scope>
<exclusions>
<exclusion>
<groupId>io.prometheus</groupId>
<artifactId>prometheus-metrics-tracer-initializer</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
Expand Down
7 changes: 4 additions & 3 deletions ...pentelemetry/src/test/java/io/prometheus/metrics/exporter/opentelemetry/ExemplarTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import static org.awaitility.Awaitility.await;

import com.github.tomakehurst.wiremock.http.Request;
import com.github.tomakehurst.wiremock.junit5.WireMockRuntimeInfo;
import com.github.tomakehurst.wiremock.junit5.WireMockTest;
import com.github.tomakehurst.wiremock.matching.MatchResult;
import com.github.tomakehurst.wiremock.matching.ValueMatcher;
Expand All @@ -34,7 +35,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

@WireMockTest(httpPort = 4317)
@WireMockTest
class ExemplarTest {
private static final String ENDPOINT_PATH = "/v1/metrics";
private static final int TIMEOUT = 3;
Expand All @@ -45,10 +46,10 @@ class ExemplarTest {
private OpenTelemetryExporter openTelemetryExporter;

@BeforeEach
void setUp() {
void setUp(WireMockRuntimeInfo wireMockRuntimeInfo) {
openTelemetryExporter =
OpenTelemetryExporter.builder()
.endpoint("http://localhost:4317")
.endpoint(wireMockRuntimeInfo.getHttpBaseUrl())
.protocol("http/protobuf")
.intervalSeconds(1)
.buildAndStart();
Expand Down
Loading