fix: harden Buffer collection and stripe indexing#2289
Open
arnabnandy7 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2287 and #2282 in
prometheus-metrics-core’sBuffer.Changes
Buffer.run()spin wait during collection so the buffer cannot stay active indefinitely while waiting for in-flight observations.IllegalStateException.Buffer.run()callers that intentionally returnnull.Math.floorMod(threadId, stripeCount)to avoidMath.abs(Integer.MIN_VALUE)overflow.Integer.MIN_VALUEthread-id narrowing case.Validation
mise run lint:fix.\mvnw test -pl prometheus-metrics-core '-Dtest=BufferTest' '-Dcoverage.skip=true' '-Dcheckstyle.skip=true'.\mvnw test -pl prometheus-metrics-core '-Dtest=HistogramTest#testGolangTests,BufferTest' '-Dcoverage.skip=true' '-Dcheckstyle.skip=true'.\mvnw install -pl prometheus-metrics-core -am -DskipTests '-Dcoverage.skip=true'git diff --checkNote:
mise run builddoes not run directly in this Windows shell because the task invokes Unix-style./mvnw; the equivalent Maven wrapper commands above passed.