Skip to content

WIP: Update vendored gopls to version 0.4.2 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

WIP: Update vendored gopls to version 0.4.2 #181

wants to merge 14 commits into from

Conversation

@slrtbtfs
Copy link
Member

@slrtbtfs slrtbtfs commented Jul 1, 2020

No description provided.

slrtbtfs added 14 commits July 1, 2020 16:15
@slrtbtfs
Update vendored gopls to v0.4.2
780f5d3 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix API breakage introduced by golang/tools@2595e72
4785c42 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix API breakage caused by golang/tools@2dc4334 and golang/tools@688b3c5
1483dfd 


Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix more API breakage introduced by golang/tools@2595e72
43e3af6 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix API breakage caused by golang/tools@33427f1
751448f 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix API breakage caused by golang/tools@9089ff1
bcfcb05 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix tests
4baf317 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Add missing vendored dependency "stack"
a3de975 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix using the wrong stream type
4f37e30 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Properly marshal json logs
1988c09 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Use correct JSON lib
e755346 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Remove websocket package
605765a 
The code was unused and broken due to previous API changes anyway.

If someone needs websocket support, it's a good idea to reimplement it from scratch.

Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix mock jsonrpc2 connection
9b48555 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs
Fix notImplemented tests
ac43e90 
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
slrtbtfs added a commit that referenced this pull request Jul 7, 2020
@slrtbtfs
Remove websocket package
e79a58d 
The websocket module was never finished and due to API changes in various places, doesn't work in it's current form. Also it's incompatible with #181.

If someone wants to solve #55, it's better to start over.

Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs slrtbtfs mentioned this pull request Jul 7, 2020
Merged
@slrtbtfs slrtbtfs mentioned this pull request Jul 17, 2020
Closed
slrtbtfs added a commit that referenced this pull request Jul 17, 2020
@slrtbtfs
Add missing nil pointer check
f1aa796 
Fixes #189.

This fixes some unchecked pointer accesses in the cache package.

Independently of how errors are handled, these checks should be in place.

Proper error handling as discussed in #189 and #181 can happen separately.

Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
@slrtbtfs slrtbtfs mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slrtbtfs