Repository navigation
fix: keep signed tokens out of download logs - #66
Merged
Merged
Conversation
HttpDownloader's wolfSSL path logged each request URL in full, so a redirected OPDS download printed its signed ?token= query string. The three URL log lines now print the URL up to the query string. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XgLRarbAmBVepTPKCK7mgd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: HttpDownloader's wolfSSL path logged each request URL in full. A redirected OPDS book download printed its signed
?token=query string to serial and saved logs.After: the three URL log lines (
wolfSSL rejected URL,wolfSSL GET,wolfSSL request failed) print the URL up to the?.How: a
pathOnly()helper returns the length before the query string for a%.*sformat. Same change as CrossDink 9bf2c24.Sizes vs development 2dc4839 (static RAM unchanged on both):
default): flash +96 B (6,296,057 → 6,296,153), RAM 65,232 → 65,232x4-pro-light-sleep: flash +60 B (5,600,829 → 5,600,889), RAM 118,452 → 118,452Verify on hardware: download an OPDS book that redirects to a signed URL, and check that the log's
wolfSSL GETline ends at the path.🤖 Generated with Claude Code
https://claude.ai/code/session_01XgLRarbAmBVepTPKCK7mgd
Generated by Claude Code