Skip to content

(chore) Extend fv test to verify labels are kept in sync #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
May 30, 2026
+17 −6
Merged

(chore) Extend fv test to verify labels are kept in sync #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions test/fv/clusterprofile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,9 @@ var _ = Describe("ClusterProfile controller", Label("FV"), func() {
}
Expect(k8sClient.Create(context.TODO(), srcSecret)).To(Succeed())

Byf("Creating ClusterProfile %s/%s with kubeconfig-secretreader provider", namespace, cpName)
Byf("Creating ClusterProfile %s/%s with kubeconfig-secretreader provider and initial labels", namespace, cpName)
cp := buildFvClusterProfile(cpName, namespace)
cp.Labels = map[string]string{"env": "staging"}
Expect(k8sClient.Create(context.TODO(), cp)).To(Succeed())

err := retry.RetryOnConflict(retry.DefaultRetry, func() error {
Expand Down Expand Up @@ -115,6 +116,9 @@ var _ = Describe("ClusterProfile controller", Label("FV"), func() {
Expect(sc.Spec.KubeconfigName).To(Equal(expectedSecretName))
Expect(sc.Spec.KubeconfigKeyName).To(Equal("kubeconfig"))

Byf("Verifying SveltosCluster has labels copied from ClusterProfile")
Expect(sc.Labels["env"]).To(Equal("staging"))

Byf("Waiting for SveltosCluster %s/%s to be ready", namespace, cpName)
Eventually(func() bool {
sc := &libsveltosv1beta1.SveltosCluster{}
Expand Down Expand Up @@ -143,14 +147,11 @@ var _ = Describe("ClusterProfile controller", Label("FV"), func() {
updatedKubeconfig := []byte("updated-fake-kubeconfig")
Expect(updateSecretData(srcSecret, "kubeconfig", updatedKubeconfig)).To(Succeed())

// Trigger reconciliation by updating a label on the ClusterProfile.
// Trigger reconciliation by updating labels on the ClusterProfile.
// The controller predicate returns true when labels change.
Expect(k8sClient.Get(context.TODO(),
types.NamespacedName{Namespace: namespace, Name: cpName}, cp)).To(Succeed())
if cp.Labels == nil {
cp.Labels = make(map[string]string)
}
cp.Labels["reconcile"] = randomString()
cp.Labels["env"] = "prod"
Expect(k8sClient.Update(context.TODO(), cp)).To(Succeed())

Eventually(func() bool {
Expand All @@ -162,6 +163,16 @@ var _ = Describe("ClusterProfile controller", Label("FV"), func() {
return bytes.Equal(s.Data["kubeconfig"], updatedKubeconfig)
}, timeout, pollingInterval).Should(BeTrue())

Byf("Verifying SveltosCluster labels are updated after ClusterProfile label change")
Eventually(func() string {
current := &libsveltosv1beta1.SveltosCluster{}
if err := k8sClient.Get(context.TODO(),
types.NamespacedName{Namespace: namespace, Name: cpName}, current); err != nil {
return ""
}
return current.Labels["env"]
}, timeout, pollingInterval).Should(Equal("prod"))

Byf("Deleting ClusterProfile and verifying SveltosCluster and managed Secret are removed")
Expect(k8sClient.Get(context.TODO(),
types.NamespacedName{Namespace: namespace, Name: cpName}, cp)).To(Succeed())
Expand Down