Repository navigation
Fix flaky drift-detection-manager group tests: wait for the cache - #2104
Merged
gianlucam76 merged 1 commit intoNov 15, 2026
Merged
gianlucam76 merged 1 commit into
gianlucam76 merged 1 commit into
Conversation
The specs of "clusters deleted while they are in a group" wrote the group ConfigMaps and read them back right away through testEnv.Client, which is served from a cache. A stale read made removeStaleGroupMembers miss the deleted cluster, or the final check see the old members: Expected ["a-9meju91b8i", "a-9t2csubehc"] to consist of ["a-9meju91b8i"] Wait with Eventually for the groups to be visible before removing stale members, and for the result afterwards. Removing stale members is retried inside the Eventually when the Deployment survives. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specs of "clusters deleted while they are in a group" wrote the group ConfigMaps and read them back right away through testEnv.Client, which is served from a cache. A stale read made removeStaleGroupMembers miss the deleted cluster, or the final check see the old members:
Expected ["a-9meju91b8i", "a-9t2csubehc"] to consist of ["a-9meju91b8i"]
Wait with Eventually for the groups to be visible before removing stale members, and for the result afterwards. Removing stale members is retried inside the Eventually when the Deployment survives.