fix: surface every updateChartMap error in ClusterSummary status - #1967
Closed
gianlucam76 wants to merge 1 commit into
Closed
gianlucam76 wants to merge 1 commit into
gianlucam76 wants to merge 1 commit into
Conversation
prepareForDeployment only surfaced a failure to ClusterSummary.Status when updateChartMap returned apierrors.IsNotFound (a missing non-optional templateResourceRef). Every other error like an Helm chart field that fails Sveltos template instantiation only caused the ClusterSummary to be requeued for reconciliation again. The real error only ever showed up in the controller's own logs. This PR fixes that by surfacing any updateChartMap error the same way the IsNotFound case already did, dropping the type check so nothing falls through silently. Fixes projectsveltos#1960
gianlucam76
force-pushed
the
bug-1960
branch
from
September 14, 2026 06:28
3ed890d to
d1a2e63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1960
Problem
prepareForDeploymentonly surfaced a failure toClusterSummary.StatuswhenupdateChartMapreturnedapierrors.IsNotFound(a missing non-optionaltemplateResourceRef). Every other error fromupdateChartMap— e.g. a Helmchart field that fails Sveltos template instantiation — fell through to a
silent requeue: no
featureSummariesentry, no failure message, retryingforever with nothing visible from
kubectl get clustersummaryalone. The realerror only ever showed up in the addon-controller pod logs.
Note: the exact repro in the issue (a bad
helmCharts[].valuestemplate) isalready blocked by #1956, which excludes
Valuesfrom templating on thispath. The underlying status-visibility bug is still very much live for every
other templated
HelmChartfield though (ReleaseName,RepositoryURL,ChartVersion, ...), so the fix and test target one of those instead.Fix
Drop the
apierrors.IsNotFoundtype check: surface anyupdateChartMaperrorthe same way that case already did.
Testing
Added
prepareForDeployment surfaces an updateChartMap template failure in ClusterSummary status, using a Helm chart with an unclosed template action inReleaseName(a generic template-parse error, notapierrors.IsNotFound).Verified the test fails without the fix (no
FeatureHelmstatus entry at all)and passes with it (
FeatureStatusFailedNonRetriable+ failure message). Fullcontrollerssuite passes.🤖 Generated with Claude Code
https://claude.ai/code/session_011kChqpPVTNXqjF7NJXUKzP